Contributors Meetup Async Update - September 2nd, 2023 - September 15th, 2023

[itsjeyd (Tim Krones (OpenCraft) - https://opencraft.com/help)]

Re: PR review processes

@antoviaque

@Natalia_Choconta

Identify MFEs and new repos earlier and review the processes for enabling them. Advocate for better documentation and easier configuration while there’s still time to make changes.

@jalondonot Maybe a solution to this would be to include someone from the BTR working groups in reviews of new repos & MFEs going forward? @itsjeyd Do we have a way to implement this for all PRs with our current processes? I’m guessing we currently only have a formal process for the OSPRs - but maybe we should have one for all PRs, to enable things like this?

You’re right, we only have a formal process for OSPRs right now (at least as far as I’m aware).

In that context we could consider making it part of the workflow to ping members of BTR working groups on PRs for new repos and/or MFEs.

However, to avoid introducing another source of ambiguity with the potential of slowing things down, @Michelle_Philbrick and I would need a concise reference on who to ping for which repos/under which circumstances.

In terms of implementing something like this for all PRs, I’m not sure where I would start with that to be honest At least if we’re talking about manual steps to add to PR review workflows, I think it would be challenging to get all teams to adopt and consistently apply those to the repos that they own. Offloading this type of work to a bot (as you suggested) would probably be a better option here.

@antoviaque

We have talked about introducing a bot for helping to manage OSPRs - …

For completeness’ sake, we already have the openedx-webhooks · GitHub bot

–

Re: specific PRs

@antoviaque

Still need someone with merge rights on opaque-keys to approve fix: type hints weren’t installed properly, add type hints for Django Fields by bradenmacdonald · Pull Request #259 · openedx/opaque-keys · GitHub

@braden Ah, you need a binding - I hadn’t realized that previously, I thought you only needed people to review and make comments. I’ve replied on the PR and pinged @itsjeyd for help: fix: type hints weren’t installed properly, add type hints for Django Fields by bradenmacdonald · Pull Request #259 · openedx/opaque-keys · GitHub

This PR was merged in the meantime

@antoviaque

The gradebook MFE is broken (in master). We were able to fix it for our deployment by cherry-picking this open PR: fix: replace Field.Email reference for Field.Text by dcoa · Pull Request #345 · openedx/frontend-app-gradebook · GitHub Are there any core contributors with write permission on frontend-app-gradebook who could review?
We need a review of this frontend-app-learner-dashboard PR that fixes a branding issue: fix: get brand logo file path from env by shahbaz-shabbir05 · Pull Request #205 · openedx/frontend-app-learner-dashboard · GitHub (this will be necessary before we default this MFE to be on in the next release)

[…] Similarly to my comment above to Braden and @itsjeyd – do we have a way to tell who has commit rights and can give a binding on the repo? […]

For frontend-app-learner dashboard, the Aurora team owns that repo and is slated to take on maintainership for it in the current phase of the maintainership pilot (final confirmation pending).

I pinged their main tech contact here.

As far as core contributors go, the wiki doesn’t mention anyone having access to the frontend-app-learner dashboard repo, specifically, but aside from Adolfo there are two more people with write access to frontend-all (Brian Smith and Viktor Rusakov); they might be able to help out.

For frontend-app-gradebook, Adolfo is already handling fix: replace Field.Email reference for Field.Text by dcoa · Pull Request #345 · openedx/frontend-app-gradebook · GitHub, but for future reference that repo is also owned by Aurora and confirmed to be maintained by them starting with the current phase of the maintainership pilot.

Aside from core contributors that are members of frontend-all, Sofiane Bebert has write access to the frontend-app-gradebook repo according to the wiki.