The feature is gated with the SEARCH_SKIP_SHOW_IN_CATALOG_FILTERING setting. It defaults to True which mean that courses with visibility “none” will not be excluded from the search results.
We at RaccoonGang are using mentioned filtering for courses with visibility “none” along with modification in the lms_filter_generator.py to exclude courses with visibility “about” in all our installations.
We’re assuming this behavior is the valid default one.
Having the catalog filtering enabled by default sounds like the right approach. How would you like to move this proposal forward? I would suggest taking it to the Product Working Group for comments, then taking it to the Build-Test-Release (BTR) Working Group for a more technical discussion on pros and cons. If both groups agree, then we could schedule a PR.
I agree that we should exclude both “none” and “about” from the course discovery page. It would be good to run it by Product and BTR too.
One caveate as I rememeber this would let you use the none, and the both but on about there would be an unepxected behaour I don’t remeber what is it, something related to edx-search and edx-platform override of the fitler*.
I first though that there is no way to override edx-search filttering so I came up with PR, but then, I discovered it’s not needed and there is just a setting to do just that