kmccormick
February 24, 2023, 12:00pm
1
I’m proposing some updates to OEP-18 (Python Dependency Management) , specifically around dependencies that use URLs instead of PyPI . The main change is asking that each URL-based dependency be accompanied with a link to a clean-up issue.
I don’t think the updates are big enough to warrant an arbiter, but if you disagree, let me know and I can find one
Please leave your comments and concerns on the PR. If there are no blocking concerns by end-of-day Friday March 10th then I will merge.
FYIs: @jmbowman (original author) and @cpennington (original arbiter
openedx:master ← kdmccormick:kdmccormick/url-dependency-clarifications
opened 04:16PM - 23 Feb 23 UTC
## Description
Nine different URL-specified Python dependencies had accumulat… ed in edx-platform, noticably increasing the amount time it took to install edx-platform requirements.
After many developer hours of work, we are nearly finished converting them to PyPI-hosted depencencies:
https://github.com/openedx/wg-developer-experience/issues/153
We make these OEP updates in order to clarify that URL dependencies should not be added except in the two specified circumstances and that the follow-up work of moving them to PyPI must be recorded.
## Other info
Direct link to rendered RST: https://github.com/kdmccormick/open-edx-proposals/blob/kdmccormick/url-dependency-clarifications/oeps/best-practices/oep-0018-bp-python-dependencies.rst
edx-platform PR to update CODEOWNERS and the github.in comment: https://github.com/openedx/edx-platform/pull/31824
## Comment Period
Please raise any concerns by the end of **Friday, March 3rd**.
This is great. There are other changes I might like to see (such as using a commit hash rather than a branch or tag) but this is a distinct, separable improvement and I wouldn’t want to delay it.
1 Like
.
)