Flaky Test Process

In the distant pass, edX/Open edX had a Flaky Test Process. It was written up in the wiki (before the 2U acquisition, and before OEPs existed). The old process page went to the 2U wiki, and was dropped from the Open edX wiki. Basically, we decided that flaky tests should be removed until they can be fixed.

I continue to follow that process, so I made a copy of the old Flaky Test Process page in the Open edX wiki. I believe this is a past decision that should be revived as an OEP, and updated to remove all the 2U specific ticketing, etc.

Here is a recent issue where I followed some version of this process: Fix flaky TestGetCourseUserPartitions tests · Issue #35028 · openedx/edx-platform · GitHub

Thoughts?

FYI: @feanil - both being at Axim and having made some of the original decisions with me.

I agree with this in general, if we can show that a test is flaky, then we should eject it and write up a ticket about it so that we can follow up in the future but we don’t want to slow down development because tests are flaky.

1 Like

I just want to say I haven’t seen many flaky tests these days. So I think this has worked well!

A much more common problem now is some unknown error happening on github that causes some entire test shards to not run at all, without any specific error message. I don’t know why that happens but it’s now much more common for me than a flaky test.

1 Like

A lot of this doc talks about bok choy tests, which we no longer have (:tada:)

I like it !! It should be cleaned up a bit. I wonder if you think its own OEP or an ADR on OEP-67: Standard Tools and Technologies — Open edX Proposals 1.0 documentation would be appropriate?

Thanks. I think it would be fine to be under another OEP, or anywhere. I just want it somewhere. :slight_smile:

OK! Made an issue here - ADR for Flaky Tests · Issue #599 · openedx/open-edx-proposals · GitHub - I’m going to try to draw down the open tickets on oep by end of August.

1 Like